[MOB-9258] fixed nested IsSet matching #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lso a IsSet criteria on the nested json
mprew97
requested changes
Aug 7, 2024
| return Object.keys(valueFromObj).map((key) => | ||
| this.getValueFromNestedObject(valueFromObj, key) | ||
| ); | ||
| if (typeof valueFromObj === 'object' && valueFromObj !== null) { |
There was a problem hiding this comment.
Can we add additional test coverage for this method?
There was a problem hiding this comment.
While reviewing the scenario for writing the test case, I realised that this scenario will never occur because our portal doesn't accept values as objects when creating criteria. Therefore, I have removed that method, and everything is working fine for all the criteria.
| } else { | ||
| return valueFromObj; | ||
| } | ||
| } | ||
|
|
||
| private getFieldValue(data: any, field: string): any { | ||
| const fields = field.split('.'); | ||
| return fields.reduce((acc, field) => acc?.[field], data); | ||
| return fields.reduce((value, currentField) => { |
There was a problem hiding this comment.
We have already written test case for this. You can verify that in Line no: 672 of file 'src/anonymousUserTracking/complexCriteria.test.ts' -- it('should return criteriaId 100 (complex criteria 3)'
mprew97
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket(s) if any
Description
[Web SDK] nested object isSet does not match
Test Steps
Video attached to the ticket, See a JIRA ticket for the video